-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Make IoSlice and IoSliceMut methods unstably const
#144090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @ibraheemdev
rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
If this looks good, I'll open a tracking issue and link it.
r? libs-api
@BurntSushi Friendly ping. Would you mind taking a look at this?
This seems fine; if we wind up with an obscure platform for which the vector type can't be constructed at comptime for some reason, we would probably use the unsupported fallback instead.
Nominated.
For after discussion and updates,
r? libs
db62f1f to
3cf5b88
Compare
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
FCP since this requires that any iovec-like structure is always const-constructible without calling any system API functions. This is already the case for unix and Windows.
@rfcbot merge
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:
No concerns currently listed.
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
This enables constructing
IoSliceandIoSliceMutin const contexts without users needing to break the platform abstraction by doing the cast themselves. This is useful for statics.Since all current and plausible future platforms use simple slice-like structs, this should not impose a burden when adding a new platform with a different struct.